New colors screen #2510
Merged
New colors screen #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Mar 14, 2023
Inbal-Tish
changed the title
Inbal-Tish
reviewed
Mar 16, 2023
| constructor(props) { | ||
| super(props); | ||
|
|
||
| this.extraColors = this.props.extraColors; |
There was a problem hiding this comment.
if you're in the c'tor you don't need the 'this' before props, they are passed as a parameter. By the way, you don't need a c'tor at all as you can get the props using 'this' (as you did here).
Inbal-Tish
reviewed
Mar 16, 2023
| onTokenPress = value => { | ||
| const systemColorName = Colors.getSystemColorByHex(Colors[value].toString(), [ | ||
| ...SYSTEM_COLORS, | ||
| ...(this.extraColors || []), |
There was a problem hiding this comment.
Did you check if it crashes when you spread undefined? If it is, you can set the empty array as the const default to avoid this condition... it will look and read better
There was a problem hiding this comment.
@Inbal-Tish Yes, I checked for crashes, this is why I used the condition inside the spread here.
Do you mean something like this?
const {extraColors=[]} = this.props
inside the relevant function.
|
@adids1221 Looks good. 2 little comments |
Inbal-Tish
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New colors screen.
Changelog
New colors screen.