-
Notifications
You must be signed in to change notification settings - Fork 734
initialNumToRender prop added to WheelPicker FlatList props #2521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adids1221,
I don't really like the Android only prop (even if the bug occurs only on Android).
Further more, I think the solution should be to allow passing the required props to solve the issue and then let the user know what they should pass (this is the same solution as the other ticket you've mentioned, see #2461).
We need the Android only prop but in the Duration Picker. TLDR: So I need to make another PR in the private repo to add this new prop to the |
As discussed, this can be handled in the |
Description
SectionWheelPicker passes
flatListProps
andstyle
to solve the item not rendering issue in wheelPicker.Changelog
SectionWheelPicker new prop
androidBigDataSection
, pass this prop when using Android to solve wheelPicker not render all the section items after selecting a value.