Skip to content

initialNumToRender prop added to WheelPicker FlatList props #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented Mar 9, 2023

Description

SectionWheelPicker passes flatListProps and style to solve the item not rendering issue in wheelPicker.

Changelog

SectionWheelPicker new prop androidBigDataSection, pass this prop when using Android to solve wheelPicker not render all the section items after selecting a value.

@adids1221 adids1221 changed the title initialNumToRender prop added to WheelPicekr -> FlatList initialNumToRender prop added to WheelPicker FlatList props Mar 29, 2023
@adids1221 adids1221 requested a review from M-i-k-e-l March 30, 2023 08:22
@adids1221 adids1221 marked this pull request as ready for review March 30, 2023 08:26
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adids1221,

I don't really like the Android only prop (even if the bug occurs only on Android).
Further more, I think the solution should be to allow passing the required props to solve the issue and then let the user know what they should pass (this is the same solution as the other ticket you've mentioned, see #2461).

@adids1221
Copy link
Contributor Author

adids1221 commented Apr 2, 2023

Hi @adids1221,

I don't really like the Android only prop (even if the bug occurs only on Android). Further more, I think the solution should be to allow passing the required props to solve the issue and then let the user know what they should pass (this is the same solution as the other ticket you've mentioned, see #2461).

We need the Android only prop but in the Duration Picker.
DurationPicker will have Android only prop as a boolean, and the logic must be handled in this case in the sectionWheelPicker.
If this prop passed from the DurationPicker then the sectionWheelPicker will go over each section, extract the section's length, and set it to the flatList props we want to pass to the WheelPicker in this case.

TLDR:
We must have this prop in the DurationPicker and the logic, in this case, must be handled by us in the sectionWheelPicker.

So I need to make another PR in the private repo to add this new prop to the DurationPicker.

@adids1221 adids1221 requested a review from M-i-k-e-l April 2, 2023 08:02
@M-i-k-e-l
Copy link
Collaborator

As discussed, this can be handled in the DurationPicker (only)

@adids1221 adids1221 marked this pull request as draft April 13, 2023 09:03
@adids1221 adids1221 closed this Apr 20, 2023
@adids1221 adids1221 deleted the fix/WheelPicker_data_missing branch April 20, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants