Skip to content

Expose TextFieldRef type #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions demo/src/screens/componentScreens/TextFieldScreen.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import _ from 'lodash';
import React, {Component} from 'react';
import {TextInput, StyleSheet, ScrollView, ActivityIndicator} from 'react-native';
import {Assets, Colors, Spacings, Typography, View, Text, Button, Keyboard, TextField, TextFieldMethods} from 'react-native-ui-lib'; //eslint-disable-line
import {StyleSheet, ScrollView, ActivityIndicator} from 'react-native';
import {Assets, Colors, Spacings, Typography, View, Text, Button, Keyboard, TextField, TextFieldRef} from 'react-native-ui-lib'; //eslint-disable-line
const {KeyboardAwareInsetsView} = Keyboard;

const priceFormatter = Intl.NumberFormat('en-US');

export default class TextFieldScreen extends Component {
input = React.createRef<TextInput>();
input2 = React.createRef<TextInput>();
inputWithValidation = React.createRef<TextFieldMethods>();
input = React.createRef<TextFieldRef>();
input2 = React.createRef<TextFieldRef>();
inputWithValidation = React.createRef<TextFieldRef>();
state = {
errorPosition: TextField.validationMessagePositions.TOP,
shouldDisable: false,
Expand Down Expand Up @@ -162,7 +162,6 @@ export default class TextFieldScreen extends Component {

<View row top marginT-s4>
<TextField
// @ts-expect-error
ref={this.inputWithValidation}
placeholder="Enter full name"
validate="required"
Expand Down
4 changes: 3 additions & 1 deletion src/incubator/TextField/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ import {
InternalTextFieldProps,
ValidationMessagePosition,
FieldContextType,
TextFieldMethods
TextFieldMethods,
TextFieldRef
} from './types';
import {shouldHidePlaceholder} from './Presenter';
import Input from './Input';
Expand Down Expand Up @@ -218,6 +219,7 @@ export {
FieldContextType,
StaticMembers as TextFieldStaticMembers,
TextFieldMethods,
TextFieldRef,
ValidationMessagePosition as TextFieldValidationMessagePosition
};
export default asBaseComponent<TextFieldProps, StaticMembers>(forwardRef(TextField as any), {
Expand Down
2 changes: 2 additions & 0 deletions src/incubator/TextField/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -259,3 +259,5 @@ export interface TextFieldMethods {
validate: () => boolean;
isValid: () => boolean;
}

export type TextFieldRef = TextInput & TextFieldMethods;
2 changes: 1 addition & 1 deletion src/incubator/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// export {default as Calendar} from './Calendar';
export {default as ExpandableOverlay} from './expandableOverlay';
// @ts-ignore
export {default as TextField, TextFieldProps, FieldContextType, TextFieldMethods, TextFieldValidationMessagePosition} from './TextField';
export {default as TextField, TextFieldProps, FieldContextType, TextFieldMethods, TextFieldRef, TextFieldValidationMessagePosition} from './TextField';
export {default as Toast, ToastProps, ToastPresets} from './toast';
export {default as TouchableOpacity, TouchableOpacityProps} from './TouchableOpacity';
export {default as PanView, PanViewProps, PanViewDirections, PanViewDismissThreshold} from './panView';
Expand Down
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import * as Incubator from './incubator';
export {
TextFieldProps,
TextFieldMethods,
TextFieldRef,
TextFieldValidationMessagePosition,
FieldContextType,
ToastProps,
Expand Down