Skip to content

fix wheelpicker in android #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 1, 2023
Merged

fix wheelpicker in android #2558

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0c07bf3
fix wheelpicker in android
adids1221 Apr 16, 2023
fbbd420
Removed initialNumToRender, removed style
adids1221 Apr 17, 2023
e68a2b7
removed itemLength variable
adids1221 Apr 19, 2023
687d792
Merge branch 'master' into fix/WheelPicker_android
adids1221 Apr 25, 2023
ba13827
opt-out
adids1221 Apr 25, 2023
8f66a9a
added flatListProps to wheelPicker.api
adids1221 Apr 27, 2023
197255a
added note to the api.json file
adids1221 May 1, 2023
e121a85
refactor the nore
adids1221 May 1, 2023
a62d548
fixed note
adids1221 May 1, 2023
e5ad818
minor fix
adids1221 May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/WheelPicker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ const WheelPicker = ({
const prevIndex = useRef(currentIndex);
const [flatListWidth, setFlatListWidth] = useState(0);
const keyExtractor = useCallback((item: ItemProps, index: number) => `${item}.${index}`, []);
const androidFlatListProps = useMemo(() => {
if (Constants.isAndroid) {
return {
maxToRenderPerBatch: items.length
};
}
}, [items]);

useEffect(() => {
// This effect making sure to reset index if initialValue has changed
Expand Down Expand Up @@ -323,6 +330,7 @@ const WheelPicker = ({
<View row centerH>
<View flexG>
<AnimatedFlatList
{...androidFlatListProps}
{...flatListProps}
testID={`${testID}.list`}
listKey={`${testID}.flatList`}
Expand Down
8 changes: 7 additions & 1 deletion src/components/WheelPicker/wheelPicker.api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "WheelPicker",
"category": "form",
"description": "A customizable WheelPicker component",
"note": "When using Android by default the FlatList will have 'maxToRenderPerBatch' prop set to items.<br/>length to solve FlatList bug on Android, you can override it by passing your own 'flatListProps' with 'maxToRenderPerBatch' prop.<br/>See the RN FlatList issue for more info: https://github.com/facebook/react-native/issues/15990",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it but I assume items.<br/>length will look strange, it should probably be in the same line and preferably with code look (if possible in the note): items.length

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, checked.
Wrapped with <code>Text...</code>

"example": "https://github.com/wix/react-native-ui-lib/blob/master/demo/src/screens/componentScreens/WheelPickerScreen.tsx",
"images": [],
"props": [
Expand Down Expand Up @@ -33,7 +34,12 @@
"default": "center"
},
{"name": "separatorsStyle", "type": "ViewStyle", "description": "Extra style for the separators"},
{"name": "testID", "type": "string", "description": "test identifier"}
{"name": "testID", "type": "string", "description": "test identifier"},
{
"name": "flatListProps",
"type": "FlatListProps",
"description": "Props to be sent to the FlatList."
}
],
"snippet": [
"<WheelPicker",
Expand Down