improve getColorTint util to support custom colors tints #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Oct 14, 2018
| const colorKey = _.findKey(this, (value, key) => this[key] === color); | ||
|
|
||
| if (_.isUndefined(tintKey)) { | ||
| throw new Error('"Colors.getColorTint" must accept a color and tintKey params'); | ||
| console.error('"Colors.getColorTint" must accept a color and tintKey params'); |
There was a problem hiding this comment.
If you don't return here you might use the undefined 'tintKey' later
Inbal-Tish
reviewed
Oct 14, 2018
| return color; | ||
| } else if (tintLevel <= BASE_COLOR_LEVEL) { | ||
| const darkRatio = darkRatios[tintLevel - 1]; | ||
| return one(color).darken(darkRatio).hex(); |
There was a problem hiding this comment.
What if 'color' is undefined? Won't it crash here?
Inbal-Tish
approved these changes
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.