Skip to content

Upgrade reanimated to 2.17 #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demo/src/screens/componentScreens/SortableListScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ const SortableListScreen = () => {
const Container = locked ? View : TouchableOpacity;
return (
<Container
// TODO: fix Android selection color
style={[styles.itemContainer, isSelected && styles.selectedItemContainer]}
onPress={() => toggleItemSelection(item)}
// overriding the BG color to anything other than white will cause Android's elevation to fail
Expand Down
5 changes: 4 additions & 1 deletion demo/src/screens/incubatorScreens/IncubatorToastScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, {Component} from 'react';
import {ScrollView, StyleSheet} from 'react-native';
import {Assets, Colors, View, Button, Text, Incubator} from 'react-native-ui-lib';
import {renderMultipleSegmentOptions, renderBooleanOption, renderRadioGroup} from '../ExampleScreenPresenter';
import {gestureHandlerRootHOC} from 'react-native-gesture-handler';

const {Toast} = Incubator;

Expand All @@ -18,7 +19,7 @@ const TOAST_MESSAGES = {
offline: 'Check Your Internet Connection'
};

export default class ToastsScreen extends Component {
class ToastsScreen extends Component {
showToast = false; // keep this state in class instance for immediate response
state = {
visible: false,
Expand Down Expand Up @@ -179,6 +180,8 @@ export default class ToastsScreen extends Component {
}
}

export default gestureHandlerRootHOC(ToastsScreen);

const styles = StyleSheet.create({
scrollView: {
paddingBottom: 80
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"react-native-haptic-feedback": "^1.11.0",
"react-native-linear-gradient": "2.6.2",
"react-native-navigation": "7.32.1",
"react-native-reanimated": "2.14.0",
"react-native-reanimated": "2.17.0",
"react-native-shimmer-placeholder": "^2.0.6",
"react-native-svg": "^13.7.0",
"react-native-svg-transformer": "^0.14.3",
Expand Down
1 change: 1 addition & 0 deletions src/components/picker/NativePicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import TouchableOpacity from '../touchableOpacity';
import {Colors} from '../../style';
import {WheelPicker} from '../../incubator';

// TODO: remove this file?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is related to the reanimated upgrade?

Copy link
Collaborator Author

@M-i-k-e-l M-i-k-e-l May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses Incubator.WheelPicker (which is using reanimated) so I wanted to test it, but nothing is currently using this file; I did not want to make this PR any larger or risk anything so I've added a TODO.

class NativePicker extends Component {
static displayName = 'NativePicker';

Expand Down
1 change: 1 addition & 0 deletions src/components/sharedTransition/SharedArea.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const {interpolate: _interpolate, interpolateNode} = Animated;
const Easing = EasingNode || _Easing;
const interpolate = interpolateNode || _interpolate;

// TODO: 2.17 breaks Android (at list the screen, the image is not shown) - move to incubator?
class SharedArea extends Component {
displayName = 'IGNORE';
static propTypes = {
Expand Down