fixed maxChips props when chips passed as prop #2680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When adding the example in the ticket to the PlaygroundScreen I get a red screen: |
fixed |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
M-i-k-e-l
reviewed
Feb 18, 2024
src/components/chipsInput/index.tsx
Outdated
Comment on lines
141
to
146
| if (maxChips && index < maxChips) { | ||
| return renderChip({index, chip, isMarkedForRemoval}); | ||
| } | ||
| if (!maxChips) { | ||
| return renderChip({index, chip, isMarkedForRemoval}); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (maxChips && index < maxChips) { | |
| return renderChip({index, chip, isMarkedForRemoval}); | |
| } | |
| if (!maxChips) { | |
| return renderChip({index, chip, isMarkedForRemoval}); | |
| } | |
| if (!maxChips || (maxChips && index < maxChips)) { | |
| return renderChip({index, chip, isMarkedForRemoval}); | |
| } |
There was a problem hiding this comment.
And maxChips is missing from the dependencies
M-i-k-e-l
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ChipsInput -
maxChipsprop support when passing chips list as a prop.Changelog
ChipsInput -
maxChipsprop support when passing chips list as a prop.Additional info
#2166