testkit new useScrollabe driver, new Carousel driver for testings #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps: |
M-i-k-e-l
reviewed
Aug 29, 2023
M-i-k-e-l
reviewed
Aug 30, 2023
|
|
||
| await driver.scroll(Constants.screenWidth); //NOTE: first scroll doesn't fire onScroll | ||
| await driver.scroll({contentOffset: {x: Constants.screenWidth}}); //NOTE: first scroll doesn't fire onScroll |
There was a problem hiding this comment.
I just realized that you are receiving props in this method which the usage is more complex than it should be.
This will be much easier:
await driver.scroll({x: Constants.screenWidth}, lessCommonOptionObject); // don't change the name for the second param :)
M-i-k-e-l
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useScrollable- a new driver to the testKit to support testing lists and lists-based components.Changelog
useScrollable- a new driver to the testKit to support testing lists and lists-based components.Additional info