Skip to content

on filtered children change cb #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2023
Merged

on filtered children change cb #2725

merged 3 commits into from
Sep 4, 2023

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented Aug 24, 2023 •
edited
Loading

Description

Picker onSearchChange callback now supports filteredChildren prop to get the filtered list after a search.

Changelog

Picker onSearchChange callback now supports filteredChildren prop.

Additional info

@adids1221 adids1221 requested a review from lidord-wix August 28, 2023 08:26
@adids1221 adids1221 marked this pull request as ready for review August 28, 2023 08:27
lidord-wix
lidord-wix approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, see the conflict
BTW, is there a ticket for that?

@adids1221
Copy link
Contributor Author

Approved, see the conflict BTW, is there a ticket for that?

Yes, the request came from the support channel, I've posted the PR there and I'll update the user ticket.

@adids1221 adids1221 merged commit f1e6dd4 into master Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adids1221 @lidord-wix