Add display property to dateTimePicker #2733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested review from
M-i-k-e-l and
Inbal-Tish
and removed request for
M-i-k-e-l
Inbal-Tish
approved these changes
Dec 6, 2023
|
@ethanshar Approved. Seems you have conflicts... |
|
@Inbal-Tish I will fix them asap. |
|
Sorry @Inbal-Tish I made a mistake by closing the issue. Reopended now with the changes and conflict fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add display property to dateTimePicker component to be able to change it
Changelog
Add display property to dateTimePicker component. Default value is
spinneron iOS anddefaulton Android. Previously,spinner(iOS) andundefined(Android) was passed toRNDateTimePicker.