Skip to content

[WEB] Allow pass id to SvgImage #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2023
Merged

[WEB] Allow pass id to SvgImage #2740

merged 3 commits into from
Oct 9, 2023

Conversation

tourofer
Copy link
Contributor

@tourofer tourofer commented Sep 10, 2023

Description

Allow passing id to the svg tag.
the css style will be passed via className

Changelog

Allow passing id to SvgImage on web

Additional info

@AmitShwarts AmitShwarts changed the title Allow changing SVG size in style [WEB] Allow pass id to SvgImage Oct 3, 2023
@AmitShwarts AmitShwarts marked this pull request as ready for review October 3, 2023 10:04
Copy link
Contributor

@AmitShwarts AmitShwarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me
@adids1221 WDYT?

@AmitShwarts AmitShwarts requested a review from adids1221 October 3, 2023 10:30
@adids1221 adids1221 added the Important for Next Release PR that must be included in the release version label Oct 5, 2023
@OrenZak
Copy link
Contributor

OrenZak commented Oct 8, 2023

@adids1221 can we merge ?

@ethanshar ethanshar merged commit 32ad53c into master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants