Skip to content

DynamicFonts - remove buttonNegative #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged

DynamicFonts - remove buttonNegative #2750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/components/DynamicFonts/PermissionsAcquirer.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const AndroidOsVersion = Platform.OS === 'android' ? Platform.constants.Release
export type PermissionsAcquirerProps = {
requestPermissionsTitle?: string;
requestPermissionsMessage?: string;
requestPermissionsNegativeButtonText?: string;
requestPermissionsPositiveButtonText?: string;
permissionsRefusalMessage?: string;
permissionsErrorMessage?: string;
Expand All @@ -13,7 +12,6 @@ export type PermissionsAcquirerProps = {
const DEFAULT_PERMISSIONS_ACQUIRER_PROPS: Required<PermissionsAcquirerProps> = {
requestPermissionsTitle: 'Allow Storage Access',
requestPermissionsMessage: 'Give the app permission to access the files and storage on your device.',
requestPermissionsNegativeButtonText: 'Cancel',
requestPermissionsPositiveButtonText: 'Continue',
permissionsRefusalMessage: 'Please edit your permission settings to continue.',
permissionsErrorMessage: `We weren't able to obtain the required permissions. Please try Again.`
Expand All @@ -38,9 +36,6 @@ export default class PermissionsAcquirer {
const result = await PermissionsAndroid.request(PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE, {
title: this.props.requestPermissionsTitle ?? DEFAULT_PERMISSIONS_ACQUIRER_PROPS.requestPermissionsTitle,
message: this.props.requestPermissionsMessage ?? DEFAULT_PERMISSIONS_ACQUIRER_PROPS.requestPermissionsMessage,
buttonNegative:
this.props.requestPermissionsNegativeButtonText ??
DEFAULT_PERMISSIONS_ACQUIRER_PROPS.requestPermissionsNegativeButtonText,
buttonPositive:
this.props.requestPermissionsPositiveButtonText ??
DEFAULT_PERMISSIONS_ACQUIRER_PROPS.requestPermissionsPositiveButtonText
Expand Down