Skip to content

Colors - generateColorPalette - avoid reversing on dark mode #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2023
Merged

Colors - generateColorPalette - avoid reversing on dark mode #2757

merged 3 commits into from
Sep 28, 2023

Conversation

Inbal-Tish
Copy link
Collaborator

Description

Colors - generateColorPalette - add the option to avoid reversing on dark mode

Changelog

Colors - generateColorPalette - add the option to avoid reversing on dark mode

ethanshar
ethanshar approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
We will have to add unit tests for this logic

@Inbal-Tish
Copy link
Collaborator Author

Approved We will have to add unit tests for this logic

Yes, you're right. I added tests for light mode to make sure the logic didn't change

@Inbal-Tish Inbal-Tish merged commit 4fe73e5 into master Sep 28, 2023
@Inbal-Tish Inbal-Tish deleted the feat/Colors_palette_avoidReverseDM branch December 7, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inbal-Tish @ethanshar