Skip to content

Fixed chips scroll on press #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fixed chips scroll on press #2766

merged 1 commit into from
Oct 17, 2023

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Oct 16, 2023 •
edited
Loading

Description

Fixed bug where clicking on the chips wouldn't scroll to the appropriate section.

Changelog

Fixed chips scroll to section on demo app.

Additional info

@nitzanyiz nitzanyiz requested a review from ethanshar October 16, 2023 07:55
ethanshar
ethanshar approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
It worked before, so I can only assume it's an issue with react-native after we upgraded to rn71
Anyway, looks good 👌

@ethanshar ethanshar merged commit 796d2f3 into master Oct 17, 2023
@nitzanyiz nitzanyiz deleted the fix/chips-scrolltosection branch October 17, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitzanyiz @ethanshar