Skip to content

Fix/colorpicker debounce #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Fix/colorpicker debounce #2777

merged 6 commits into from
Oct 25, 2023

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Oct 23, 2023

Description

Added migrate prop to the ColorPickerDialog. The prop wasn't passed so the new slider was not used.

Changelog

ColorPickerDialog now uses a new slider for better performance.

Additional info

WOAUILIB-3631

@nitzanyiz nitzanyiz requested a review from ethanshar October 23, 2023 13:30
@nitzanyiz nitzanyiz marked this pull request as ready for review October 23, 2023 13:30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in this file are only formatting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Should I just revert them?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can keep it

@ethanshar ethanshar merged commit af12326 into master Oct 25, 2023
@nitzanyiz nitzanyiz deleted the fix/colorpicker-debounce branch October 30, 2023 11:42
nitzanyiz added a commit that referenced this pull request Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants