Skip to content

View test driver and background tests #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2023
Merged

View test driver and background tests #2783

merged 6 commits into from
Oct 31, 2023

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Oct 29, 2023

Description

Added a driver for the view component, currently exposing getStyle on top of the basic driver functionality and a test for the background color.

Changelog

View - Added a test driver.

Additional info

WOAUILIB-3820

@nitzanyiz nitzanyiz requested a review from M-i-k-e-l October 29, 2023 11:35
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Approved, however we need to add a test in private (that's the code that was broken)

@nitzanyiz nitzanyiz requested a review from M-i-k-e-l October 30, 2023 14:58
@M-i-k-e-l
Copy link
Collaborator

M-i-k-e-l commented Oct 31, 2023

You can keep the test IMO, feel free to merge either way

@nitzanyiz nitzanyiz merged commit 5d61336 into master Oct 31, 2023
@nitzanyiz nitzanyiz deleted the viewBackgroundTests branch October 31, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants