Expandable testids #2784
Merged
Expandable testids #2784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Oct 30, 2023
Comment on lines
51
to
54
| /** | ||
| * Testing identifier | ||
| */ | ||
| testID?: string; |
There was a problem hiding this comment.
I don't think you don't need to define a testID prop on TouchableOpacity, it already inherit it from React Native's TouchableOpacity
There was a problem hiding this comment.
You're right. Fixed.
nitzanyiz
force-pushed
the
expandable-testids
branch
2 times, most recently
from
923a7bf to
02cdeea
Compare
nitzanyiz
force-pushed
the
expandable-testids
branch
from
02cdeea to
80d565f
Compare
ethanshar
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added testid prop to the expandable section component. The testid is assigned to the touchable opacity component.
Changelog
ExpandableSection - Added testing identifier prop, testID.
Additional info
WOAUILIB-3816