PickerItem - support asynchronous and ignore selection #2787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Oct 31, 2023
| @@ -238,7 +239,7 @@ export interface PickerItemProps { | |||
| * Callback for onPress action | |||
| * @param selected true\false in multi mode and undefined in single mode | |||
| */ | |||
| onPress?: (selected?: boolean) => void; | |||
| onPress?: (selected: boolean | undefined, props: any) => void | Promise<boolean>; | |||
There was a problem hiding this comment.
I would add the note you added there about returning false to disable closing the picker
|
Approved, wrote a small comment |
M-i-k-e-l
added
the
Important for Next Release
M-i-k-e-l
deleted the
feat/picker-item-on-press-support-ignore-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PickerItem - support asynchronous and ignore selection
Changelog
PickerItem - support asynchronous and ignore selection
Relates to the FontPicker
Additional info
None