Feat/picker use dialog 2 #2804
Merged
Feat/picker use dialog 2 #2804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
the
Important for Next Release
M-i-k-e-l
reviewed
Nov 19, 2023
| enableModalBlur={false} | ||
| onChange={item => this.setState({option: item})} | ||
| topBarProps={{title: 'Languages'}} | ||
| useDialog |
There was a problem hiding this comment.
Not sure it's related to the PR, but passing useSafeArea does not work together with useDialog
- It can be passed via
customPickerProps.dialogProps
There was a problem hiding this comment.
Fix the flexness issue of the FlatList inside the dialog
| searchPlaceholder={'Search a language'} | ||
| > | ||
| {_.map(dialogOptions, option => ( | ||
| <Picker.Item key={option.value} value={option.value} label={option.label} disabled={option.disabled}/> |
There was a problem hiding this comment.
Last items are not properly scrollable \ visible
| testID | ||
| } = props; | ||
| const context = useContext(PickerContext); | ||
| const [wheelPickerValue, setWheelPickerValue] = useState<PickerSingleValue>(context.value ?? items?.[0].value); | ||
| const wrapperContainerStyle = useMemo(() => { | ||
| const shouldFlex = Constants.isWeb ? 1 : useDialog ? 0 : 1; |
There was a problem hiding this comment.
This looks like it should be only flex
There was a problem hiding this comment.
Didnt change the name, but changed the logic
src/components/picker/index.tsx
Outdated
| )} | ||
| </ExpandableOverlay> | ||
| { | ||
| // @ts-expect-error |
There was a problem hiding this comment.
Why not {/* @ts-expect-error */}? (I assume the whole change here is due to alignment)
|
@M-i-k-e-l ping on this one |
M-i-k-e-l
approved these changes
Nov 21, 2023
Comment on lines
+42
to
+43
| const shouldFlex = true; | ||
| const style = {flex: shouldFlex ? 1 : 0, maxHeight: Constants.isWeb ? Constants.windowHeight * 0.75 : undefined}; |
There was a problem hiding this comment.
Suggested change
| const shouldFlex = true; | |
| const style = {flex: shouldFlex ? 1 : 0, maxHeight: Constants.isWeb ? Constants.windowHeight * 0.75 : undefined}; | |
| const style = {flex: 1, maxHeight: Constants.isWeb ? Constants.windowHeight * 0.75 : undefined}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR based on PR Adi started working for a fix for Web.
We're adding some support for features that we later use in private's Picker.
useDialog - ability to show Picker as dialog
renderCustomDialogHeader - support rendering a custom dialog header by passing a callback. We pass to the callback to onDone, onCancel of the Picker so the user (us in this case) can do what they wish
Changelog
Support rendering Picker as dialog and also render custom dialog header
Additional info