Skip to content

Moved ColorPicker to FC. #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 24, 2023
Merged

Moved ColorPicker to FC. #2822

merged 9 commits into from
Dec 24, 2023

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Nov 23, 2023

Description

Created FC of the ColorPicker.

Changelog

ColorPicker - Changed to FC.

@nitzanyiz nitzanyiz requested a review from ethanshar November 23, 2023 11:00
@nitzanyiz nitzanyiz marked this pull request as ready for review November 26, 2023 08:53
@nitzanyiz nitzanyiz changed the title ColorPicker FC Moved ColorPicker to FC. Nov 30, 2023
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, wrote small comments. Also you need to resolve conflicts

state = {
show: false
};
const showDialog = () => setShow(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap with useCallback

@nitzanyiz nitzanyiz requested a review from ethanshar December 5, 2023 11:37
@nitzanyiz nitzanyiz requested review from Inbal-Tish and removed request for ethanshar December 7, 2023 11:23
@nitzanyiz nitzanyiz assigned Inbal-Tish and unassigned ethanshar Dec 24, 2023
@Inbal-Tish Inbal-Tish merged commit 4f51f4f into master Dec 24, 2023
@nitzanyiz nitzanyiz deleted the toFC/ColorPicker branch December 24, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants