Moved ColorPickerDialog to FC. #2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanyiz
changed the title
ethanshar
reviewed
Dec 4, 2023
Moved some constants to the presenter file
ethanshar
reviewed
Dec 4, 2023
| import {Colors} from '../../style'; | ||
| import {ColorPickerDialogProps} from './ColorPickerDialog'; | ||
| import {BORDER_RADIUS} from './ColorPickerPresenter'; | ||
| type HeaderProps = Pick<ColorPickerDialogProps, 'doneButtonColor' | 'accessibilityLabels' | 'testID'> & { |
There was a problem hiding this comment.
Add space between imports and global declarations
| @@ -0,0 +1,108 @@ | |||
| import React, {useRef} from 'react'; | |||
| import {View, TouchableOpacity, Text} from 'react-native-ui-lib'; | |||
There was a problem hiding this comment.
You can't/shouldn't import from uilib in a source code, you should import from the relevant components file directly
this can cause cyclic requires and TS build issues
Changed imports to import from relative path and not ui-lib
ethanshar
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the ColorPickerDialog to a FC.
Changelog
ColorPickerDialog - Changed to FC