Fix/carousel android rtl jumps #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Nov 30, 2023
src/components/carousel/index.tsx
Outdated
| const {containerStyle, children, testID} = this.props; | ||
|
|
||
| const {containerStyle, children: propsChildren, testID} = this.props; | ||
| const children = Constants.isRTL && Constants.isAndroid ? React.Children.toArray(propsChildren) : propsChildren; |
There was a problem hiding this comment.
For some reason on RTL android sends the children reversed.
src/components/carousel/index.tsx
Outdated
| } | ||
|
|
||
| goToNextPage() { | ||
| const {currentPage} = this.state; | ||
| const pagesCount = presenter.getChildrenLength(this.props); | ||
| const {loop} = this.props; | ||
| let nextPageIndex; | ||
|
|
||
| if (currentPage === pagesCount + 1) { | ||
| return this.goToPage(0, false); |
There was a problem hiding this comment.
Did you mean to:
this.goToPage(0, false);
return;
nitzanyiz
force-pushed
the
fix/carouselAndroidRTLJumps
branch
from
71bec5b to
34f5fa7
Compare
|
I moved the goToPage 0 condition to inside the loop condition. Its works even when outside but I think it might make some problems because its not supposed to happen if not looping. |
M-i-k-e-l
reviewed
Dec 4, 2023
src/components/carousel/index.tsx
Outdated
| @@ -454,14 +457,14 @@ class Carousel extends Component<CarouselProps, CarouselState> { | |||
|
|
|||
| renderCounter() { | |||
| const {pageWidth, showCounter, counterTextStyle} = this.props; | |||
| const {currentStandingPage} = this.state; | |||
M-i-k-e-l
reviewed
Dec 4, 2023
nitzanyiz
commented
Dec 4, 2023
| const scrollContainerStyle = this.shouldUsePageWidth() | ||
| ? {paddingRight: this.getItemSpacings(this.props)} | ||
| : undefined; | ||
| const snapToOffsets = this.getSnapToOffsets(); | ||
| const marginBottom = Math.max(0, this.getContainerPaddingVertical() - 16); | ||
| const ScrollContainer = animatedScrollOffset ? Animated.ScrollView : ScrollView; | ||
| const contentOffset = this.getInitialContentOffset(snapToOffsets); | ||
| const _style = Constants.isRTL && Constants.isAndroid ? [styles.invertedView, style] : style; |
There was a problem hiding this comment.
I inverted the view on android rtl so it would behave the same as on ios.
M-i-k-e-l
approved these changes
Dec 5, 2023
src/components/carousel/index.tsx
Outdated
| @@ -305,7 +307,7 @@ class Carousel extends Component<CarouselProps, CarouselState> { | |||
| onMomentumScrollEnd = () => { | |||
| // finished full page scroll | |||
| const {currentStandingPage, currentPage} = this.state; | |||
| const index = this.getCalcIndex(currentPage); | |||
| const index = currentPage; | |||
nitzanyiz
added a commit
that referenced
this pull request
Dec 19, 2023
This reverts commit b997db4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a problem with the currentPage calculation. I removed the usage of the getCalcIndex from the goToPage and moved the page calculation in the goToNextPage. On android RTL the children is passed reversed for some reason so I revered so the first item will show first.
Changelog
Carousel - Fixed Android RTL jumps on random items.
Additional info