Moved SliderGroup to FC. #2832
Merged
Moved SliderGroup to FC. #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nitzanwix Please add the "changelog" filed on all PRs |
Inbal-Tish
reviewed
Dec 5, 2023
|
|
||
| constructor(props: SliderGroupProps) { | ||
| super(props); | ||
| const valueSetter = useCallback((value: tinycolor.ColorFormats.HSLA) => { |
There was a problem hiding this comment.
'valueSetter' is not a proper name for a callback. We usually use the name of the prop it is passed to or as an action describing what this method does
There was a problem hiding this comment.
Is _setValue better?
Inbal-Tish
reviewed
Dec 5, 2023
Inbal-Tish
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converted SliderGroup to FC.
Changelog
SliderGroup - Moved to a FC.
Additional info