Moved ColorSliderGroup to FC. #2833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanyiz
requested review from
ethanshar and
Inbal-Tish
and removed request for
ethanshar
Inbal-Tish
reviewed
Dec 5, 2023
Inbal-Tish
reviewed
Dec 5, 2023
| labelsStyle, | ||
| accessible, | ||
| labels, | ||
| migrate |
There was a problem hiding this comment.
Seems like you could pick up the props you need for the group (container) and pass the others as "others" to the ColorSlider, no?
There was a problem hiding this comment.
Most of them, Yeah. Fixed.
Inbal-Tish
reviewed
Dec 6, 2023
|
@nitzanwix Looks great. I left a small coment |
Inbal-Tish
reviewed
Dec 12, 2023
| return null; | ||
| }; | ||
| const onValueChange = useCallback((value: string) => { | ||
| props.onValueChange?.(value); |
There was a problem hiding this comment.
props can potentially be undefied so add a ? after
Inbal-Tish
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved ColorSliderGroup to FC.
Changelog
Additional info