Moved GradientSlider to FC. #2834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanyiz
changed the title
ethanshar
reviewed
Dec 27, 2023
| <View marginB-s3 row> | ||
| <Text marginR-s2>Custom Color</Text> | ||
| <Switch value={customColor} onValueChange={setCustomColor}/> | ||
| </View> | ||
| <GradientSlider type={GradientSlider.types.HUE} color={color as string} onValueChange={setColor}/> | ||
| { | ||
| // @ts-ignore |
There was a problem hiding this comment.
You shouldn't ignore TS here, you have a justified TS error.
Notice that the typing your declare for GradientSlider includes sliderContext, but this is actually an internal prop you are passing... internally.
So the right way to approach this is to not include this type (sliderContext) in GradientSlider props.
Instead, you can expect the sliderContext prop only in the component's code. Like this..
type Props = GradientSliderComponentProps & ForwardRefInjectedProps & {sliderContext: SliderContextProps};
const GradientSlider = (props: Props) => {.....
| onValueChange={this.onGradientValueChange} | ||
| /> | ||
| { | ||
| // @ts-ignore |
There was a problem hiding this comment.
Same here, see if my comment above fix this issue
nitzanyiz
force-pushed
the
toFC/GradientSlider
branch
from
49f8bff to
035333c
Compare
nitzanyiz
force-pushed
the
toFC/GradientSlider
branch
from
d76f317 to
4f948b5
Compare
ethanshar
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved GradientSlider to a FC.
Changelog
GradientSlider - Moved to FC.
Additional info
None