Design Kits issues #2836
Merged
Design Kits issues #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
changed the title
ethanshar
added
the
Important for Next Release
Inbal-Tish
reviewed
Dec 6, 2023
src/style/__tests__/colors.spec.js
Outdated
| @@ -111,7 +111,7 @@ describe('style/Colors', () => { | |||
| uut.getColorTint('#3F88C5', 20); | |||
| uut.getColorTint('#3F88C5', 50); | |||
| uut.getColorTint('#3F88C5', 70); | |||
| const cachedPalette = uut.generateColorPalette.cache.get('#3F88C5'); | |||
| const cachedPalette = uut.generateColorPalette.cache.get('#3F88C5_'); | |||
There was a problem hiding this comment.
Why the underscore in the hax string?
|
@ethanshar Approved. I left a small comment |
Inbal-Tish
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have 2 fixes here
Colors.generateColorPaletteapi is memoized but it didn't handle well the options argument so we got mixed resultsThis PR fix it by passing a custom resolver that takes the options into account
The reason we rebuild it is because this code is heavily based on reanimated and require us to initialize the whole animation
Changelog
Fix
Colors.generateColorPalettememoized result (handle cache properly)Fix TabController.TabBar not responding to change in labelColor/selectedLabelColor
Additional info