Avoid failing rgba API #2838
Merged
Avoid failing rgba API #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
approved these changes
Dec 6, 2023
| @@ -129,7 +130,8 @@ export class Colors { | |||
| blue = validateRGB(p3!); | |||
| opacity = p4; | |||
| } else { | |||
| throw new Error('rgba can work with either 2 or 4 arguments'); | |||
| LogService.error('Colors.rgba fail due to invalid arguments'); | |||
There was a problem hiding this comment.
I think it should be failed (also in tests)
There was a problem hiding this comment.
What do you mean should be failed?
LogService.error doesn't throw an error
src/style/__tests__/colors.spec.js
Outdated
| const SYSTEM_COLORS = ['grey', 'white', 'black']; | ||
| const GetColorsByHexOptions = {validColors: SYSTEM_COLORS}; | ||
|
|
||
| describe('style/Colors', () => { | ||
| const logServiceSpy = jest.spyOn(LogService, 'error'); | ||
| // jest.mock('../../services/LogService'); |
Co-authored-by: Miki Leib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid failing Colors.rgba API on invalid input to avoid app crashes
Changelog
Avoid failing Colors.rgba API on invalid input to avoid app crashes
Additional info