Maybe fix assets 2 #2856
Merged
Maybe fix assets 2 #2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Dec 25, 2023
src/utils/imageUtils.ts
Outdated
Comment on lines
12
to
20
| let isSvg = false; | ||
| if (typeof source === 'function') { | ||
| isSvg = true; | ||
| } else if (isSvgUri(source)) { | ||
| isSvg = true; | ||
| } else if (Constants.isWeb && isSvgData(source)) { | ||
| isSvg = true; | ||
| } | ||
| return isSvg; |
There was a problem hiding this comment.
Why not keep like this?
return (typeof source === 'function') || isSvgUri(source) || (Constants.isWeb && isSvgData(source));
src/utils/imageUtils.ts
Outdated
| @@ -1,14 +1,23 @@ | |||
| import get from 'lodash/get'; | |||
| import {ImageProps} from 'react-native'; | |||
| import Assets from '../assets'; | |||
| import {Constants} from 'src/commons/new'; | |||
There was a problem hiding this comment.
Fix import path to
import {Constants} from '../commons/new';
ethanshar
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
isSVGlogic on web to ignore base64 assetsChangelog
Fix
isSVGlogic on web to ignore base64 assetsAdditional info
N/A