Skip to content

TextFiled - fix incompatible ref types TS error #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Inbal-Tish
Copy link
Collaborator

@Inbal-Tish Inbal-Tish commented Jan 2, 2024

Description

Fix ts error:

Types of property 'ref' are incompatible.
Type 'Ref<TextInput> | undefined' is not assignable to type 'LegacyRef<Component<TextFieldProps, any, any>> | undefined'.

To reproduce add this code to playgroundScreen:

export const ExpandableTextField = ({...textFieldProps}: TextFieldProps) => {
  return <TextField {...textFieldProps}/>;
};

Changelog

TextField - fix TS error: Types of property 'ref' are incompatible

Additional info

Ticket 3899

@ethanshar ethanshar merged commit 017a7cd into master Jan 3, 2024
M-i-k-e-l added a commit that referenced this pull request Jan 8, 2024
adids1221 pushed a commit that referenced this pull request Jan 8, 2024
adids1221 pushed a commit that referenced this pull request Jan 8, 2024
M-i-k-e-l added a commit that referenced this pull request Jan 9, 2024
…not assigned to TextInput (#2868)" (#2883)"

This reverts commit 4ab1190.
adids1221 pushed a commit that referenced this pull request Jan 9, 2024
…not assigned to TextInput (#2868)" (#2883)" (#2884)

This reverts commit 4ab1190.
adids1221 pushed a commit that referenced this pull request Jan 11, 2024
@Inbal-Tish Inbal-Tish deleted the fix/TextField_types branch January 14, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants