Skip to content

fix: add null check for ReactScreenMonitor #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

ddx-510
Copy link
Contributor

@ddx-510 ddx-510 commented Jan 4, 2024

Description

Add an extra null check before adding the listener

Changelog

Check getWindow() is not null before getDecorView()

Additional info

#2875 Plz help check if this is the cause

@ddx-510
Copy link
Contributor Author

ddx-510 commented Jan 4, 2024

@M-i-k-e-l Sorry to trouble you, but may I ask whether this change can be made?

Checked in my own package, indeed solve issue #2875

Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@M-i-k-e-l M-i-k-e-l merged commit 3502b24 into wix:master Jan 7, 2024
@tlenclos
Copy link

@M-i-k-e-l Hello ! Can you release this hotfix please ?

@M-i-k-e-l
Copy link
Collaborator

We should be releasing a new version towards the end of this week

@TolgaYigit
Copy link
Contributor

TolgaYigit commented Jan 15, 2024

This should be released ASAP. The issue blocks my whole EAS cloud builds.

@M-i-k-e-l
Copy link
Collaborator

Version 7.14.5 is out and includes this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants