Ref Typings #2885
Merged
Ref Typings #2885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jan 14, 2024
| const customSlider = useRef<typeof Incubator.Slider>(); | ||
| const negativeSlider = useRef<typeof Incubator.Slider>(); | ||
| const rangeSlider = useRef<typeof Incubator.Slider>(); | ||
| const slider = useRef<Incubator.SliderRef>(null); |
There was a problem hiding this comment.
Why do we need to pass null here?
There was a problem hiding this comment.
When using it without null, the type of the ref is Ref<SliderRef | undefined> which causes an error. This error also occurs with regular react native refs. For example using React Native TextInput.
| @@ -213,4 +213,5 @@ GradientSlider.displayName = 'GradientSlider'; | |||
| GradientSlider.types = GradientSliderTypes; | |||
|
|
|||
| // eslint-disable-next-line max-len | |||
| export default asBaseComponent<GradientSliderProps, typeof GradientSlider>(forwardRef(asSliderGroupChild(forwardRef(GradientSlider)))); | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
Do you know why we have an error here?
If it's too complicated we can solve it another time..
ethanshar
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added RefInterface to the our forwardRef function. Adding this generic sets the type of the ref to the specific interface so when passing ref to a one of our components it will show a ts error when passing an incompatible interface ref.
Changelog
Added generic typings to the forwardRef and in the asBaseComponent usage.
Additional info
None