TextField - create new driver and refactor tests to it #2890
Conversation
M-i-k-e-l
requested review from
ethanshar,
adids1221,
Inbal-Tish and
nitzanyiz
| @@ -5,7 +5,7 @@ import {usePressableDriver} from '../../testkit/new/usePressable.driver'; | |||
| export const TextDriver = (props: ComponentProps) => { | |||
| const driver = usePressableDriver<TextProps>(useComponentDriver(props)); | |||
|
|
|||
| const getText = () => { | |||
| const getText = (): React.ReactNode | undefined => { | |||
There was a problem hiding this comment.
Doesn't it suppose to return a string?
There was a problem hiding this comment.
I thought so, and then I saw it does not, although I think we do compare it to string in tests, maybe we should return as string | undefined so it's more clear?
I am really not sure
There was a problem hiding this comment.
Let's see if it meets us when we or others use it..
There was a problem hiding this comment.
As you've mentioned, this can technically be a Text child
| import View from '../../../components/view'; | ||
| import {TextFieldDriver} from '../TextField.driver'; | ||
| import {TextFieldDriver} from '../TextField.driver.new'; |
There was a problem hiding this comment.
Let's remove the old file
There was a problem hiding this comment.
I think we can't do it yet because we still have other components that depend on the old ones.
| import _ from 'lodash'; | ||
| import {fireEvent} from '@testing-library/react-native'; | ||
| import {TextFieldProps} from './types'; | ||
| import {useComponentDriver, ComponentProps} from '../../testkit/new/Component.driver'; |
There was a problem hiding this comment.
Is this a good name for the driver arguments? Perhaps ComponentDriverArguments or DriverArguments will be better?
There was a problem hiding this comment.
If you're talking about ComponentProps then this is not the PR to change it; feel free to create a PR for it.
Description
TextField - create new driver and refactor tests to it
Changelog
TextField - create new driver and refactor tests to it
Additional info
None