Skip to content

Switch - refactor driver to use new implementation #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

Inbal-Tish
Copy link
Collaborator

Description

Switch - refactor driver to use new implementation

Changelog

Switch - refactor driver to use new implementation

Additional info

@Inbal-Tish Inbal-Tish added this to the Quality milestone Jan 15, 2024
@ethanshar
Copy link
Collaborator

@Inbal-Tish Is this ready for review?

@Inbal-Tish
Copy link
Collaborator Author

@Inbal-Tish Is this ready for review?

Yes

…s/Driver_Switch

# Conflicts:
#	src/components/switch/switch.driver.ts
Copy link
Contributor

@adids1221 adids1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed this log, please solve the testKit conflict

}
export const SwitchDriver = (props: ComponentProps) => {
const driver = usePressableDriver<SwitchProps>(useComponentDriver(props));
console.log('INBAL - SwitchDriver:', driver.getProps());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this log

…s/Driver_Switch

# Conflicts:
#	src/testkit/index.ts
@Inbal-Tish Inbal-Tish merged commit 090e236 into master Jan 17, 2024
@Inbal-Tish Inbal-Tish deleted the tests/Driver_Switch branch March 7, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants