new button driver, image driver, testing #2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adids1221
requested review from
ethanshar,
Inbal-Tish,
M-i-k-e-l and
nitzanyiz
M-i-k-e-l
reviewed
Jan 16, 2024
Comment on lines
20
to
30
| const isLabelExist = () => { | ||
| return labelDriver.exists(); | ||
| }; | ||
|
|
||
| const getIconElement = () => { | ||
| return iconDriver.getElement(); | ||
| }; | ||
|
|
||
| const isIconExist = () => { | ||
| return iconDriver.exists(); | ||
| }; |
There was a problem hiding this comment.
The convention is to:
const getLabel = () => {
return labelDriver;
};
...
Or in case you have a logic change:
const getLabel = () => {
const exists = (): boolean => {
// New logic
};
return {...labelDriver, exists};
};
...
M-i-k-e-l
reviewed
Jan 16, 2024
Inbal-Tish
reviewed
Jan 16, 2024
| @@ -0,0 +1,33 @@ | |||
| import {ButtonProps} from './ButtonTypes'; | |||
There was a problem hiding this comment.
The props should be exported from the component IMO
There was a problem hiding this comment.
Ethan commented on my PR that it should be from the types, not sure why it's named ButtonTypes and not types but it's not related to this PR
M-i-k-e-l
reviewed
Jan 16, 2024
Comment on lines
17
to
23
| const getLabel = () => { | ||
| const exists = (): boolean => { | ||
| return labelDriver.exists(); | ||
| }; | ||
|
|
||
| return {...labelDriver, exists}; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const getLabel = () => { | |
| const exists = (): boolean => { | |
| return labelDriver.exists(); | |
| }; | |
| return {...labelDriver, exists}; | |
| }; | |
| const getLabel = () => { | |
| return labelDriver; | |
| }; |
M-i-k-e-l
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Button - create new driver and refactor tests to it
Changelog
Button - create new driver and refactor tests to it
Additional info