Automation gap - WOAUILIB-3704 #2902
Conversation
|
Its fails with error when I try to reset the modules after each test. |
| @@ -44,3 +45,45 @@ describe('Text', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| // jest.mock('react-native/Libraries/ReactNative/I18nManager', () => ({ | |||
There was a problem hiding this comment.
@nitzanwix
Instead of mocking RN it might be simpler to override/mock our Constants.isRLT value
See here
https://github.com/wix/react-native-ui-lib/blob/master/src/components/sortableGridList/__tests__/usePresenter.spec.tsx
There was a problem hiding this comment.
He's testing the style here, so I don't think that'll work.
Although I'm not sure this is the best way to test this bug, an alternative might be with screenshots and I think we don't want to rely on that here.
There was a problem hiding this comment.
I'm trying to test the following. overriding/mocking in Constants will work for RTL but I want to also mock the platform. Currently this doesn't work and pops a invalid hook usage error.
react-native-ui-lib/src/components/text/index.tsx
Lines 195 to 203 in 068b4d0
nitzanyiz
changed the title
| Constants.isRTL = isRTL; | ||
| }; | ||
|
|
||
| describe('Automation gap', () => { |
There was a problem hiding this comment.
Consider adding tests for LTR as well
There was a problem hiding this comment.
For text? Or in general?
There was a problem hiding this comment.
The same tests but with LTR
| const {onPress} = textProps; | ||
| const renderTree = render(<WrapperScreenWithText onPress={onPress}/>); | ||
| const textDriver = TextDriver({renderTree, testID: TEXT_ID}); | ||
| return {renderTree, textDriver}; |
There was a problem hiding this comment.
Don't think you need to return renderTree here
| Constants.isRTL = isRTL; | ||
| }; | ||
|
|
||
| describe('Automation gap', () => { |
There was a problem hiding this comment.
Please change the name
Description
Added automation gap for text alignment on rtl.
Changelog
N/A
Additional info
WOAUILIB-3704