new segemntTypography prop #2929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jan 31, 2024
| /** | ||
| * Segment typography | ||
| */ | ||
| segmentTypography?: string; |
There was a problem hiding this comment.
Consider changing to a more general prop
We can have segmentStyle or actually segmentLabelStyle
ethanshar
reviewed
Feb 5, 2024
| <Reanimated.Text | ||
| fsTagName={'unmasked'} | ||
| numberOfLines={1} | ||
| style={[animatedTextStyle, Typography.text90, segmentLabelStyle]} |
There was a problem hiding this comment.
I think it's better to set the animatedTextStyle at the end so it won't get overridden by the user's style..
The screen is ready with example |
ethanshar
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SegmentControl support in custom typography, new `segmentTypography" prop
Changelog
SegmentControl support in custom typography
Additional info