icon support in badge #2941
Merged
icon support in badge #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Inbal-Tish this PR is mentioned in related PR in the private. |
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
reviewed
Feb 8, 2024
src/components/icon/index.tsx
Outdated
| const containerStyle = badgeProps?.containerStyle; | ||
| const badgePosition: StyleProp<ViewStyle> = { | ||
| position: 'absolute', | ||
| top: -3 |
There was a problem hiding this comment.
why did you set it to -3 if you're changing it later? I'd set the default here, for the badge, and if it is a pimple override.
Inbal-Tish
reviewed
Feb 8, 2024
src/components/icon/index.tsx
Outdated
| top: -3 | ||
| }; | ||
| if (isPimple()) { | ||
| badgePosition.right = -2; |
There was a problem hiding this comment.
these values should be a const. Are they not supposed to be dynamic or they should be the same for all icon/badge sizes?
There was a problem hiding this comment.
I'm referring to the -2 and the -5
There was a problem hiding this comment.
In the last commit I added support for dynamic badge size as we spoke.
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
reviewed
Feb 8, 2024
Inbal-Tish
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Iconsupport in badge.Added 2 new props
badgeProps | hideBadgeto theIconcomponent.Changelog
Iconsupport in badge.Additional info