Infra/date time picker allow migration to new dialog #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
requested review from
ethanshar
and removed request for
Inbal-Tish
ethanshar
approved these changes
Feb 12, 2024
| @@ -15,6 +15,7 @@ import {Colors} from '../../style'; | |||
| import Assets from '../../assets'; | |||
| import {Constants, asBaseComponent, BaseComponentInjectedProps} from '../../commons/new'; | |||
| import TextField, {TextFieldProps, TextFieldMethods} from '../textField'; | |||
| import {DialogMigrationProps} from '../../incubator/Dialog'; | |||
There was a problem hiding this comment.
consider adding type keyword
M-i-k-e-l
deleted the
infra/date-time-picker-allow-migration-to-new-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DateTimePicker - allow migration to new the Dialog via migrateDialog
Moved some props from
ExpandableOverlayso they can be used in other places.Changelog
DateTimePicker - allow migration to new the Dialog via migrateDialog
Additional info
MADS-3966