-
Notifications
You must be signed in to change notification settings - Fork 734
SectionWheelPicker driver to take testIDs from children #2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nitzanyiz
merged 11 commits into
master
from
fix/SectionWheelPickerDriver_section_drivers
Apr 24, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2ce3632
Changed sections drivers finding
nitzanyiz 05b5230
removed main testID from the section testid in the driver
nitzanyiz 761a672
removed extra import
nitzanyiz 3dc4552
Changed to take testIDs from children
nitzanyiz 5e55413
Fixed testId and removed unused variable
nitzanyiz 0d8b608
Merge remote-tracking branch 'origin' into fix/SectionWheelPickerDriv…
nitzanyiz 2cc2fd0
formattings
nitzanyiz b778066
change section type cheking to be mroe readable
nitzanyiz b17e540
changed implementation
nitzanyiz 78352e4
Merge remote-tracking branch 'origin' into fix/SectionWheelPickerDriv…
nitzanyiz ae56484
removed generic
nitzanyiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
13 changes: 4 additions & 9 deletions
13
src/components/sectionsWheelPicker/SectionsWheelPicker.driver.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,17 @@ | ||
import _ from 'lodash'; | ||
import {useComponentDriver, ComponentProps} from '../../testkit/new/Component.driver'; | ||
import {WheelPickerDriver} from '../WheelPicker/WheelPicker.driver'; | ||
import {WheelPickerItemValue} from '../WheelPicker'; | ||
import {SectionsWheelPickerProps} from './index'; | ||
|
||
export const SectionsWheelPickerDriver = <T extends WheelPickerItemValue>(props: ComponentProps) => { | ||
export const SectionsWheelPickerDriver = (props: ComponentProps) => { | ||
const driver = useComponentDriver(props); | ||
const sections = driver.getElement().children as SectionsWheelPickerProps<T>; | ||
const sectionsDrivers = _.map(sections, (_, index) => { | ||
const sections = driver.getElement().children as SectionsWheelPickerProps['sections']; | ||
const sectionsDrivers = _.map(sections, (section, index) => { | ||
const sectionTestID = `${props.testID}.${index}`; | ||
return WheelPickerDriver({ | ||
renderTree: props.renderTree, | ||
testID: sectionTestID | ||
testID: section?.testID || sectionTestID | ||
}); | ||
}); | ||
|
||
|
||
|
||
|
||
return {...driver, sections, sectionsDrivers}; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.