Skip to content

fix: [MADS-4071] clear picker value on web #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

AmitShwarts
Copy link
Contributor

@AmitShwarts AmitShwarts commented Mar 18, 2024

Description

when passing undefined after a value already selected, it's not being cleared on the UI.

Changelog

fix: clearing picker value on web

Additional info

MADS-4071

@AmitShwarts AmitShwarts changed the title fix: clear picker value on web fix: [MADS-4071] clear picker value on web Mar 18, 2024
@AmitShwarts AmitShwarts requested a review from adids1221 March 18, 2024 13:02
@AmitShwarts AmitShwarts requested a review from M-i-k-e-l March 18, 2024 13:25
@adids1221
Copy link
Contributor

adids1221 commented Mar 18, 2024

@M-i-k-e-l seems good to me, I also checked it on TextField.
and it's not looking something risky (if we want to HF this), WDYT ?

@M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l seems good to me, I also checked it on TextField. and it's not looking something risky, WDYT ?

  • checking it now on private *

Can't say I like it but not sure there's a different way, I think it's an issue with RN's TextInput

@AmitShwarts
Copy link
Contributor Author

can we please hotfix it?

@adids1221 adids1221 merged commit 22fae02 into master Mar 19, 2024
@adids1221 adids1221 deleted the fix/clear-picker-value-on-web branch March 19, 2024 09:22
adids1221 pushed a commit that referenced this pull request Mar 19, 2024
* fix: clear picker value on web

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants