Incubator Slider - fix step interpolation #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Mar 20, 2024
| @@ -58,7 +58,6 @@ export function validateValues(props: SliderProps) { | |||
| export function getStepInterpolated(trackWidth: number, minimumValue: number, maximumValue: number, stepXValue: SharedValue<number>) { | |||
| 'worklet'; | |||
| const outputRange = [0, trackWidth]; | |||
| const inputRange = minimumValue < 0 ? | |||
| [Math.abs(maximumValue), Math.abs(minimumValue)] : [minimumValue, maximumValue]; | |||
| const inputRange = minimumValue < 0 ? [0, Math.abs(minimumValue)] : [0, maximumValue]; | |||
There was a problem hiding this comment.
I see that it works, but Im not sure I understand the bug.
Can you explain what happens here that caused this?
There was a problem hiding this comment.
Ok, I added refinement to explain: The interpolation finds a value from one range at a different range. In this case, the value is the stepXValue, the x point equal to the step. This value is used to calculate the new location from the current location - where to jump to. Since this is an x value it doesn't care if the initial value is 12, it needs to start from 0 to give a value of x, so instead of defining the range 12 to 50, I'll define it as 0 to 38.
Inbal-Tish
added
the
Important for Next Release
ethanshar
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incubator Slider - fix step interpolation
to reproduce:
<Incubator.Slider value={sliderValue} onValueChange={setSliderValue} step={1} minimumValue={12} maximumValue={50} />Slider or press track to see the slider jumps.
Changelog
Incubator Slider - fix step interpolation
Additional info
ticket 4070