Skip to content

passing display undefined to svgs #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Mar 28, 2024

Description

Passing undefined to display prop of Svg in order to handle svgs with display="block" which causes any error.
Not sure if this should be in the change log

Changelog

SvgImage - Fix svgs with display="block" causes crashes.

Additional info

MADS-4017

@nitzanyiz nitzanyiz requested a review from ethanshar March 28, 2024 12:02
@nitzanyiz nitzanyiz marked this pull request as ready for review March 28, 2024 12:02
@ethanshar ethanshar merged commit 1cd67e4 into master Apr 1, 2024
@ethanshar ethanshar deleted the infra/passDipsplayUndefinedToSvg branch April 1, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants