Assets is now category in the release notes #3005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adids1221 Can we do the same to intl? |
ethanshar
reviewed
Apr 1, 2024
scripts/prReleaseNotesCommon.js
Outdated
| @@ -99,12 +100,14 @@ function getPRsByType(PRs) { | |||
| fixes.push(pr); | |||
| } else if (pr.branch.startsWith('infra/')) { | |||
| infra.push(pr); | |||
| } else if (pr.branch.startsWith('assets/') || pr.branch.startsWith('Assets/')) { | |||
There was a problem hiding this comment.
instead of checking both assets and Assets you can use toLowerCase on the branch name and check only against assets
Inbal-Tish
reviewed
Apr 7, 2024
scripts/prReleaseNotesCommon.js
Outdated
| ...categories, | ||
| {name: 'others', branch: '', title: 'OTHERS'}, | ||
| { | ||
| name: 'silentPRs', |
Inbal-Tish
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release notes script now accepts
categoriesto make it generic for privatecategories.The script will support any category in the structure of:
{name: 'category', branch: 'cat/', title: 'title for the release notes'}Changelog
none
Additional info