ColorSliderGroup - refactor #3009
Conversation
GradientSlider - change to useContext instead of asSliderGroupChild, fix typo and change useEffect to useDidUpdate.
…nto infra/ColorSliderGroup_refactor
There was a problem hiding this comment.
Looks good. Wrote couple of comments, also I noticed a weird bug, I'm not sure if it's a regression, but there's a small flicker when you drag of the sliders in the group
See attached video
https://github.com/wix/react-native-ui-lib/assets/1780255/5bf210f5-68c5-404f-b9f8-e418caf3c5dd
| @@ -172,6 +157,5 @@ GradientSlider.displayName = 'GradientSlider'; | |||
| GradientSlider.types = GradientSliderTypes; | |||
| // @ts-expect-error | |||
| export default asBaseComponent<GradientSliderProps, ComponentStatics<typeof GradientSlider>>( | |||
| // @ts-expect-error | |||
| forwardRef(asSliderGroupChild(forwardRef(GradientSlider))) | |||
| forwardRef(forwardRef(GradientSlider)) | |||
There was a problem hiding this comment.
You have forwardRef twice
| @@ -172,6 +157,5 @@ GradientSlider.displayName = 'GradientSlider'; | |||
| GradientSlider.types = GradientSliderTypes; | |||
| // @ts-expect-error | |||
| export default asBaseComponent<GradientSliderProps, ComponentStatics<typeof GradientSlider>>( | |||
There was a problem hiding this comment.
We can add another simplification
Replace asBaseComponent HOC with the useThemeProps (see usages in View component)
There was a problem hiding this comment.
I got issues with the statics and the forwardRef so I decided to leave it
There was a problem hiding this comment.
That works for me or at least It didn't throw any errors...
export default forwardRef<GradientSliderProps<string | HSLA>, ComponentStatics<typeof GradientSlider>>(GradientSlider);
There was a problem hiding this comment.
Yep, I didn't move the forwardRef... I'll make the change
Fixed |
…nto infra/ColorSliderGroup_refactor
…nto infra/ColorSliderGroup_refactor
Check if ColorPicker works for you? |
I can move them... wired |
Description
ColorSliderGroup - refactor
Changelog
ColorSliderGroup - refactor
Additional info
ticket 4107