Skip to content

bottom validation message should render only if validation message sent #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

adids1221
Copy link
Contributor

Description

TextField bottom view should render the validationMessage only if the user passed validationMessage.
Currently the validationMessage renders most of the times because the default value for validationMessagePosition is bottom and break the alignment when the user passes bottomAccessory by it self.

Changelog

TextField bottom view should render the validationMessage only if the user passed validationMessage.

Additional info

@Inbal-Tish
Copy link
Collaborator

@adids1221 Can you please check if this change doesn't break the charCounter, when renders alone, from being pushed to the right

@Inbal-Tish Inbal-Tish merged commit f83ce96 into master Apr 3, 2024
@Inbal-Tish Inbal-Tish deleted the fix/TextField_bottom_view_alignment branch April 3, 2024 13:08
@adids1221
Copy link
Contributor Author

As we spoke it's doesn't break it, it works fine 👍

@ethanshar
Copy link
Collaborator

@adids1221 @Inbal-Tish
We are reverting this change.
The validation message was meant to be rendered in any case because it's keeping the space for the message. Otherwise we'll have "jumps" in the screen

nitzanyiz added a commit that referenced this pull request Apr 17, 2024
@nitzanyiz nitzanyiz mentioned this pull request Apr 17, 2024
nitzanyiz added a commit that referenced this pull request Apr 17, 2024
nitzanyiz added a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants