Slider/add throttleTime prop #3020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
the
Important for Next Release
Inbal-Tish
reviewed
Apr 9, 2024
src/incubator/Slider/index.tsx
Outdated
| @@ -278,10 +283,22 @@ const Slider = React.memo((props: Props) => { | |||
| } | |||
| }, 200), [onValueChange]); | |||
|
|
|||
| const _onValueChange = useCallback((value: number) => { | |||
There was a problem hiding this comment.
Why not pass the throttle wait (200/100 to 0) instead of having code duplications?
There was a problem hiding this comment.
@Inbal-Tish
I talked with Liat about it already, right now even without the throttle it doesn't work so good..
There was a problem hiding this comment.
added throttleTime prop instead 🙏
liatnetach
changed the title
ethanshar
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add throttleTime prop in Slider component
Changelog
Add throttleTime prop in Slider component
Additional info