Overlay component borderRadius fix #3058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
May 8, 2024
src/components/overlay/index.tsx
Outdated
| </> | ||
| ); | ||
| } | ||
| const isVertical = type === OVERLY_TYPES.VERTICAL; |
There was a problem hiding this comment.
Do you need to check this one every render?
There was a problem hiding this comment.
I don't see you took it out of the render....
Inbal-Tish
reviewed
May 8, 2024
src/components/overlay/index.tsx
Outdated
| {type && this.renderImage(this.getStyleByType(), imageSource)} | ||
| {customContent && this.renderCustomContent()} | ||
| </> | ||
| <View style={{overflow: 'hidden', borderRadius, ...StyleSheet.absoluteFillObject}}> |
There was a problem hiding this comment.
This style can move to the styleSheet while borderRadiuse can be added to an array
There was a problem hiding this comment.
No need for absolute, pass flex
|
@adids1221 The overlay gradient is messed up in your branch, see screenshots: |
Inbal-Tish
reviewed
May 8, 2024
Inbal-Tish
reviewed
May 8, 2024
Inbal-Tish
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overlay component fix borderRadius, when using Image component with overlayType and borderRadius the Overlay is covering the Image and leaks out.
Wrapping the Overlay with View with style fix the issue.
Added an example in the screen.
Changelog
Overlay covering fix when passing borderRadius.
Additional info
ticket 4162