Fix/grid list item theme support #3059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adids1221
approved these changes
May 6, 2024
ethanshar
added a commit
that referenced
this pull request
May 7, 2024
* Remove unnecessary default values to allow theme to work * try using nvm 20 * Revert nvm to use 16 * Remove comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove defaults styling for GridListItem content in order to allow theme support (when we override theme with design kit)
I used modifiers for typographies so our logic in config files can override the font accordingly
Changelog
GridListItem - Fix unnecessary defaults to allow theme override
Additional info
MADS-4169