Skip to content

Use rowGap and columnGap feature in our GridList and SortableGridList… #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2024

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented May 9, 2024

Description

Use rowGap and columnGap feature in our GridList and SortableGridList components
We had issue with extra item spacing in the last row of the grid
This fix the issue and also use a better way to add gutter (item spacing) between grid items

Changelog

Fix GridList and SortableGridList item spacing issue (using gap feature)

Additional info

@ethanshar ethanshar requested a review from M-i-k-e-l May 9, 2024 11:13
@ethanshar ethanshar added the Important for Next Release PR that must be included in the release version label May 12, 2024
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Not sure it's a bug but now we don't have a gap after the last row (visible when there's no SafeArea)
image

@M-i-k-e-l
Copy link
Collaborator

BTW, we currently have a somewhat awkward solution to this in SortableList - we've added itemProps with margins in it.
It does allow for horizontal margins as well, but I'm not sure it's a must in a list.
We can try to change the API in the next major version, WDYT?
(It should still be a dedicated prop because we need this info for the dragging height calculation)

@ethanshar
Copy link
Collaborator Author

BTW, we currently have a somewhat awkward solution to this in SortableList - we've added itemProps with margins in it. It does allow for horizontal margins as well, but I'm not sure it's a must in a list. We can try to change the API in the next major version, WDYT? (It should still be a dedicated prop because we need this info for the dragging height calculation)

I'm less familiar with it TBH, if you feel we need to change something there then open a PR

@ethanshar ethanshar requested a review from M-i-k-e-l May 12, 2024 11:08
@M-i-k-e-l M-i-k-e-l merged commit 8ef823c into master May 16, 2024
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the fix/GridList_GapIssues branch May 16, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants