Skip to content

Add flexMigration to SortableList and SortableGridList components #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2024

Conversation

ethanshar
Copy link
Collaborator

Description

When we started wrapping our SortableList and SortableGridList components with GestureHandlerRootView we should have pass flex style so the list have a flexed behavior like other RN lists (FlatList, ScrollView, etc..)
This migration is for transition to this default behavior

Changelog

Start a migration to add flex to SortableList and SortableGridList

Additional info

MADS-4163

Copy link
Contributor

@adids1221 adids1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I think we should already open a ticket for the deprecation process.

@adids1221 adids1221 merged commit f890f88 into master May 12, 2024
1 check passed
@adids1221 adids1221 deleted the fix/SortableList_flexMigration branch May 12, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants